-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched AST benchmarks from GoogleBench to NVBench #16952
Conversation
cdf4ede
to
309a9a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean porting. appreciate the minimal diff.
309a9a2
to
40a0415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thanks!
@lamarrr Can you avoid force-pushing? It's helpful for reviewers when we can see the history. I just reviewed as you pushed, and now I don't know how to easily compare the state before and after your push. Generally, force-pushing is a last resort for us, only if it's strictly needed. |
noted! |
Co-authored-by: Yunsong Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick turnaround and addressing all my review comments!
thank you |
/merge |
Description
This merge request switches the Benchmarking solution for the AST benchmark from GoogleBench to NVBench.
It also refactors the L2 cache flushing functionality ofcuda_event_timer
into a separate functionflush_L2_device_cache
, since NVBench already performs the timing, synchronization, and timer setup necessary.Checklist